Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMSIS-NN] Support for Softmax Int16 operator #15407

Merged
merged 2 commits into from
Aug 9, 2023
Merged

[CMSIS-NN] Support for Softmax Int16 operator #15407

merged 2 commits into from
Aug 9, 2023

Conversation

Nikeran
Copy link
Contributor

@Nikeran Nikeran commented Jul 25, 2023

  • Support for int16 Softmax in CMSIS-NN
  • Supporting integration test

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 25, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Nikeran Nikeran force-pushed the CMSIS_NN_Softmax_Int16_support branch from 1567dae to 17b6616 Compare July 27, 2023 15:56
@ashutosh-arm
Copy link
Contributor

cc @lhutton1

lhutton1
lhutton1 reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikeran this looks great, thanks for the hard work on it! I had mostly stylistic changes and one comment that might be a bit more involved - happy to go through it separately

src/relay/backend/contrib/cmsisnn/compute_luts.cc Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_softmax.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_softmax.py Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Outdated Show resolved Hide resolved
Aleksei-grovety
Aleksei-grovety reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@Aleksei-grovety Aleksei-grovety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikeran! Looks good just a couple questions.

src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Show resolved Hide resolved
[CMSIS-NN] Support for Softmax Int16 operator
24e8425 
* Addressed comments regarding PR including modifying the way in which the number the constant buffers shape and number of bits are extracted
@Nikeran
Copy link
Contributor Author

Nikeran commented Aug 8, 2023

@lhutton1 would you take a look at the update to see if you find anything that needs changing?

lhutton1
lhutton1 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhutton1 lhutton1 merged commit 77b71fc into apache:main Aug 9, 2023
@lhutton1
Copy link
Contributor

lhutton1 commented Aug 9, 2023

Thanks @Nikeran @Aleksei-grovety @ashutosh-arm!

@ysh329 ysh329 mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksei-grovety Aleksei-grovety Aleksei-grovety left review comments

@ashutosh-arm ashutosh-arm ashutosh-arm left review comments

@lhutton1 lhutton1 lhutton1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nikeran @tvm-bot @ashutosh-arm @lhutton1 @Aleksei-grovety