[BugFix][TIR] ThreadSync with shared.dyn awareness #15478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue of the ThreadSync pass. Prior to this PR, the pass is not aware of `shared.dyn` scope whose users all share a same shared memory space. This feature is not necessarily already revealed in the IR at the time of applying ThreadSync. This means that when applying ThreadSync, in the IR, each buffer of `shared.dyn` scope still uses its own data Var, and ThreadSync is thus unable to detect the conflict properly and insert the sync instructions properly. This PR explicitly makes ThreadSync be aware of the `shared.dyn` scope, and redirect all the access vars of `shared.dyn` memory to a common var, so that ThreadSync analysis can find out the conflict and insert the sync instructions.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
approved these changes
Aug 4, 2023
junrushao
approved these changes
Aug 4, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Aug 4, 2023
Cherrypicked from apache#15478. This PR fixes an issue of the ThreadSync pass. Prior to this PR, the pass is not aware of `shared.dyn` scope whose users all share a same shared memory space. This feature is not necessarily already revealed in the IR at the time of applying ThreadSync. This means that when applying ThreadSync, in the IR, each buffer of `shared.dyn` scope still uses its own data Var, and ThreadSync is thus unable to detect the conflict properly and insert the sync instructions properly. This PR explicitly makes ThreadSync be aware of the `shared.dyn` scope, and redirect all the access vars of `shared.dyn` memory to a common var, so that ThreadSync analysis can find out the conflict and insert the sync instructions.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Aug 4, 2023
Cherry-picked from apache#15478. This PR fixes an issue of the ThreadSync pass. Prior to this PR, the pass is not aware of `shared.dyn` scope whose users all share a same shared memory space. This feature is not necessarily already revealed in the IR at the time of applying ThreadSync. This means that when applying ThreadSync, in the IR, each buffer of `shared.dyn` scope still uses its own data Var, and ThreadSync is thus unable to detect the conflict properly and insert the sync instructions properly. This PR explicitly makes ThreadSync be aware of the `shared.dyn` scope, and redirect all the access vars of `shared.dyn` memory to a common var, so that ThreadSync analysis can find out the conflict and insert the sync instructions.
junrushao
added a commit
that referenced
this pull request
Aug 4, 2023
Cherry-picked from #15478. This PR fixes an issue of the ThreadSync pass. Prior to this PR, the pass is not aware of `shared.dyn` scope whose users all share a same shared memory space. This feature is not necessarily already revealed in the IR at the time of applying ThreadSync. This means that when applying ThreadSync, in the IR, each buffer of `shared.dyn` scope still uses its own data Var, and ThreadSync is thus unable to detect the conflict properly and insert the sync instructions properly. This PR explicitly makes ThreadSync be aware of the `shared.dyn` scope, and redirect all the access vars of `shared.dyn` memory to a common var, so that ThreadSync analysis can find out the conflict and insert the sync instructions. Co-authored-by: Ruihang Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue of the ThreadSync pass.
Prior to this PR, the pass is not aware of
shared.dynscope whose users all share a same shared memory space. This feature is not necessarily already revealed in the IR at the time of applying ThreadSync. This means that when applying ThreadSync, in the IR, each buffer ofshared.dynscope still uses its own data Var, and ThreadSync is thus unable to detect the conflict properly and insert the sync instructions properly.This PR explicitly makes ThreadSync be aware of the
shared.dynscope, and redirect all the access vars ofshared.dynmemory to a common var, so that ThreadSync analysis can find out the conflict and insert the sync instructions.