Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Strategy] Use x86 pool schedules for arm_cpu #15506

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Aug 8, 2023

Similar to #15470, x86 schedules are used in place of generic schedules to improve performance.

Since the pooling strategy does not use OpStrategy, mocking is used to ensure the relevant schedule_pool function is called when lowing a Relay pooling operation with respect to a given target.

cc @ekalda @ashutosh-arm @neildhickey

Similar to apache#15470, x86 schedules are
used in place of generic schedules to improve performance.

Since the pooling strategy does not use `OpStrategy`, mocking is used
to ensure the relevant `schedule_pool` function is called when lowing a
Relay pooling operation with respect to a given target.

Change-Id: I782fe00e29f9c9cf41b3405d33a82a79cd85a99b
@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 8, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from ashutosh-arm and ekalda August 8, 2023 08:25
Copy link
Contributor

@ashutosh-arm ashutosh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a step in the right direction. A few minor comments/questions below.

python/tvm/relay/op/strategy/arm_cpu.py Show resolved Hide resolved
tests/python/relay/strategy/test_select_implementation.py Outdated Show resolved Hide resolved
Change-Id: I9617ec8ee6f1ca1174c938d9cc4ba21b74216612
Copy link
Contributor

@ashutosh-arm ashutosh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @lhutton1.

@lhutton1 lhutton1 merged commit 8b37d4d into apache:main Aug 9, 2023
@lhutton1 lhutton1 deleted the use-x86-pool branch August 9, 2023 08:43
@lhutton1
Copy link
Contributor Author

lhutton1 commented Aug 9, 2023

Thanks @ashutosh-arm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants