Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see an accuracy issue when FQ2I is enabled for the avg_pool2d op in the deeplab_v3 QAT model. The error seems to be happening because the underlying graph has the output of the avg_pool mapped directly to the conv2d without a quantize-dequantize layer in between.
Graph of interest
Quantization parameters after Fq2i pass:
qnn.avg_pool2d (Bs, Bz, Cs, Cz)
qnn.conv2d (Cs, Cz, As, Az)
qnn.requantize (Cs*As, 0, Cs, Cz)
Proposed fix for quantization parameters:
qnn.avg_pool2d (Bs, Bz, Bs, Bz)
qnn.conv2d (Bs, Bz, As, Az)
qnn.requantize (Cs*As, 0, Cs, Cz)
where quantized parameters As, Bs, Cs are scales and Az, Bz, Cz are zeropoints.