[TIR] Output DeclBuffer in FlattenBuffer #15757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
declbuffer_output_from_buffer_flattening
branch
from
f97dbd9 to
9875bd3
Compare
If a flattened buffer is produced for use in `BufferLoad` and `BufferStore` statements, generate a `DeclBuffer`. This is a subset of the changes made in apache#14778, broken out for ease of testing and review.
When producing a flattened buffer for use in `BufferLoad` and `BufferStore` nodes, generate a `DeclBuffer` for the flattened buffer. This is a subset of the changes made in apache#14778, broken out for ease of testing and review.
Prior to this commit, the functions in `python/tvm/relay/backend/contrib/ethosu` tracked buffers based on `tir.Var`, typically determined from `buffer_load.buffer.data`. This commit updates these funcitons to instead track based on `tir.Buffer`, now determined as `buffer_load.buffer`. This change allows for tracking of buffer objects, to determine which `DeclBuffer` statements should be removed.
Lunderberg
force-pushed
the
declbuffer_output_from_buffer_flattening
branch
from
9875bd3 to
df6f66d
Compare
|
This is blocked on the ethos-u and ethos-m codegen, which does not currently support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a flattened buffer is produced for use in
BufferLoadandBufferStorestatements, generate aDeclBuffer. This PR updates the behavior for both TE-derived schedules (tir.StorageFlattentransform) and TIR-derived schedules (tir.FlattenBuffertransform).This is a subset of the changes made in #14778, broken out for ease of testing and review.