[ACL] Update Compute Library to v23.08 #15990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Compute Library to follow latest developments in 23.08 Changelog: https://arm-software.github.io/ComputeLibrary/v23.08 Change-Id: I851851edc3e9fa0f925c37f0789d397da0fa9a66
lhutton1
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Thanks @leandron! The change log states libarm_compute_core was deprecated and that we should no longer link against it. References such as the following should be removed:
I missed this change, but thinking about it, shouldn't we introduce the CMake change by the time we actually update CI to use the new image? I tested and TVM still will build fine in the meantime. |
|
Good point, let’s do that! |
lhutton1
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Compute Library to follow latest developments in 23.08
Changelog: https://arm-software.github.io/ComputeLibrary/v23.08
cc @lhutton1 @neildhickey @ashutosh-arm for reviews