[Unity][Transform] Extract partial-tuple-usage from FuseOps #16119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
unity_transform_refactor_fuse_ops
branch
from
26b675b to
14e315e
Compare
Lunderberg
changed the title
|
All prerequisite PRs have now landed, and this PR is ready for review. |
junrushao
force-pushed
the
unity
branch
2 times, most recently
from
c95d45f to
45eeb8c
Compare
Prior to this commit, the `FuseOps` pass explicitly tracked usage of tuple arguments, to minimize the set of arguments provided to each kernel. The additional tgracking and handling of partially-used tuples makes it difficult to follow the primary changes being made by `FuseOps`. This commit implements the same functionality in terms of the `ExpandTupleArguments` and `RemoveUnusedParameters` transforms, introduced in apache#16115 and apache#16116 respectively. By using these passes before the main `FuseOps` changes, partial tuple usage is already handled at that point. This commit is intended to minimize any changes to user-facing behavior, and so these pre-process passes are currently used internally by `FuseOps`. This may be avoided in the future by pulling this internal delegation out into a lowering pipeline.
Lunderberg
force-pushed
the
unity_transform_refactor_fuse_ops
branch
from
14e315e to
a7af9b8
Compare
|
Failing unit tests are due to MSC relying on relax variable names being preserved. #16349 is submitted to fix these unit tests, after which CI can be re-run for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
FuseOpspass explicitly tracked usage oftuple arguments, to minimize the set of arguments provided to each
kernel. The additional tgracking and handling of partially-used
tuples makes it difficult to follow the primary changes being made by
FuseOps.This commit implements the same functionality in terms of the
ExpandTupleArgumentsandRemoveUnusedParameterstransforms,introduced in #16115 and
#16116 respectively. By using these
passes before the main
FuseOpschanges, partial tuple usage isalready handled at that point.
This commit is intended to minimize any changes to user-facing
behavior, and so these pre-process passes are currently used
internally by
FuseOps. This may be avoided in the future by pullingthis internal delegation out into a lowering pipeline.