Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] [Relay][Pytorch] Fix missing .dtype #16167

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[BugFix] [Relay][Pytorch] Fix missing .dtype #16167

merged 1 commit into from
Nov 28, 2023

Conversation

mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Nov 27, 2023 •
edited
Loading

self.infer_type() returns tvm.ir.TensorType so we need .dtype to get the data type.
Fix #16126
cc @jikechao @vvchernov @Hzfengsy @masahi

@mshr-h mshr-h marked this pull request as ready for review November 28, 2023 01:26
@github-actions github-actions bot requested review from Hzfengsy and masahi November 28, 2023 01:27
vvchernov
vvchernov approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@vvchernov vvchernov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jikechao
jikechao approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jikechao jikechao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mshr-h Thank you!

@masahi masahi merged commit 604b263 into apache:main Nov 28, 2023
8 of 10 checks passed
@mshr-h mshr-h deleted the fix-missing-dtype branch November 28, 2023 10:39
@ysh329 ysh329 mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikechao jikechao jikechao approved these changes

@vvchernov vvchernov vvchernov approved these changes

@masahi masahi masahi approved these changes

@Hzfengsy Hzfengsy Awaiting requested review from Hzfengsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Relay][PyTorch] aten::new_zeros support is broken with torch>=2.1.0
4 participants
@mshr-h @masahi @vvchernov @jikechao