Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated np.int in slice converter (pytorch) #16221

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

jhlee525
Copy link
Contributor

By numpy, usage of np.int has been deprecated in 1.20.

This patch fixes from np.int to int in pytorch slice converter, makes it compatible with brand-new numpy.

@mshr-h
Copy link
Contributor

mshr-h commented Dec 12, 2023

@jhlee525 Thank you for your PR!
Please fix the lint error https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-lint/detail/PR-16221/1/pipeline
Any other comments? @jikechao @vvchernov

@rebel-jhlee
Copy link
Contributor

@mshr-h Thank you. I fixed it

Copy link
Contributor

@jikechao jikechao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@tqchen tqchen merged commit a59db03 into apache:main Dec 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants