[Unity][Analysis] Handle PrimStructInfo in EraseToWellDefined #16304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `EraseToWellDefined` pass would update symbolic variable definitions in `ShapeStructInfo` and `TensorStructInfo`, but did not in `PrimStructInfo`. This commit updates the `WellDefinedEraser` to include symbolic variables defined in `PrimStructInfo`.
…r_16304 Pull in bug fix from apache#16322
slyubomirsky
approved these changes
Jan 2, 2024
`tests/python/relax/test_frontend_onnx.py::test_attention` fails for some inputs. Failures on `unity` head occurred 3/100 test cases
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jan 3, 2024
The `tests/python/relax/test_frontend_onnx.py::test_attention` unit test currently has sporadic failures (5/200 executions), which can cause failures for unrelated changes (e.g. [PR#16304](apache#16304), [CI link](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-unity/detail/PR-16304/3/pipeline)). This commit specifies a tolerance to use for comparisons, to avoid these spurious CI failures.
masahi
pushed a commit
that referenced
this pull request
Jan 3, 2024
The `tests/python/relax/test_frontend_onnx.py::test_attention` unit test currently has sporadic failures (5/200 executions), which can cause failures for unrelated changes (e.g. [PR#16304](#16304), [CI link](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-unity/detail/PR-16304/3/pipeline)). This commit specifies a tolerance to use for comparisons, to avoid these spurious CI failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
EraseToWellDefinedpass would update symbolic variable definitions inShapeStructInfoandTensorStructInfo, but did not inPrimStructInfo. This commit updates theWellDefinedEraserto include symbolic variables defined inPrimStructInfo.