Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Some fixes of ROCm codegen #16404

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[ROCm] Some fixes of ROCm codegen #16404

merged 1 commit into from
Jan 16, 2024
+108 −36

Conversation

spectrometerHBH
Copy link
Contributor

@spectrometerHBH spectrometerHBH commented Jan 15, 2024 •
edited
Loading

  • Handle tvm_thread_invariant as no op.
  • llvm.amdgcn.ds.bpermute requires i32 as its input, but it can handle all 32 bit types
  • ocml intrinsics lead to incorrect codegen when used with vectorization, remove it and use llvm intrinsics instead

@junrushao junrushao mentioned this pull request Jan 15, 2024
Closed
@spectrometerHBH @junrushao
[ROCm] Some fixes of ROCm codegen
8cd3f09 
- Handle tvm_thread_invariant as no op.
- `llvm.amdgcn.ds.bpermute` requires i32 as its input, but it can handle all 32 bit types
- ocml intrinsics lead to incorrect codegen when used with vectorization, remove it and use llvm intrinsics instead
@junrushao junrushao mentioned this pull request Jan 15, 2024
Closed
@junrushao junrushao merged commit 68be158 into apache:main Jan 16, 2024
17 checks passed
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@LeshengJin @junrushao
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
6c7c7a5 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)
junrushao added a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
7471cd1 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
@junrushao junrushao mentioned this pull request Jan 17, 2024
Merged
junrushao added a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
9cb8e28 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit to mlc-ai/relax that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
9c8cf08 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit to mlc-ai/relax that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
a7818f0 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
tqchen pushed a commit that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan (#16414)
cbe9c14 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (#16404,
  #16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit to mlc-ai/relax that referenced this pull request Jan 21, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan (#16414)
62dfa27 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
@ysh329 ysh329 mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spectrometerHBH @tqchen @junrushao