Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity] downgrade cmake version requirement #16432

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

Hzfengsy
Copy link
Member

The PR #16335 updated the CMakeLists.txt, setting the minimum version to be 3.24 for the compatibility of native CMAKE_CUDA_ARCHITECTURES.

However,

  1. This breaks the CI on image Cortex-M and Hexagon on main branch.
  2. The feature is only used when CUDA builds on AND undefined CMAKE_CUDA_ARCHITECTURES.

Hence, I move the version check logic inside the CUDA cmake file.

cc @vinx13 @tqchen

@github-actions github-actions bot requested review from tqchen and vinx13 January 19, 2024 07:14
@tqchen tqchen merged commit 4e754a7 into apache:unity Jan 19, 2024
15 checks passed
@Hzfengsy Hzfengsy deleted the unity_cmake branch January 24, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants