[Unity][Transform] Handle call_tir_inplace in FuseTIR and FuseOps
#16487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2024
slyubomirsky
changed the title
call_tir_inplace in FuseTIRcall_tir_inplace in FuseTIR and FuseOps.
Lunderberg
requested changes
Jan 30, 2024
| mutator.fused_tir_funcs_.Set(gv, fused_tir); | ||
| const auto& [prim_func, indices] = FusedTIRConstructor::GetFusedTIR(mod, gv); | ||
| mutator.fused_tir_funcs_.Set(gv, prim_func); | ||
| if (!indices.empty()) { |
There was a problem hiding this comment.
Nitpick: Using if (indices.size()) instead of if (!indices.empty()) would avoiding double-negatives and make the condition easier to read. (Though, personal preference as if (indices.size()) relies on conversion of non-zero size_t to true.)
There was a problem hiding this comment.
Kind of subjective, I think "not empty" is readable (sounds more like how it would be phrased verbally). I'll change it if you prefer it.
There was a problem hiding this comment.
Probably more personal preference, so either works.
slyubomirsky
changed the title
call_tir_inplace in FuseTIR and FuseOps.call_tir_inplace in FuseTIR and FuseOps
Lunderberg
approved these changes
Feb 5, 2024
slyubomirsky
force-pushed
the
fuse-tir-inplace
branch
from
ce9d196 to
111f08e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles in-place
PrimFuncs inFuseTIR, namely by propagating the in-place indices. This required a few updates in the two passes but nothing very heavy-duty.