[Instrument] Add default instrument to print all passes #16497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwww
approved these changes
Jan 31, 2024
A small patch to add default instruments that prints all passes before or after each pass. This is used very frequently when debugging and we don't know which pass could cause a particular change
quic-sanirudh
force-pushed
the
add_default_print_all_passes_instruments
branch
from
9ac2392 to
1679e37
Compare
Thanks for the review. I wasn't sure exactly what to check for in the tests and I've tried something simple, let me know if it can be improved. |
|
@quic-sanirudh it was landed. Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small patch to add default instruments that prints all passes before or after each pass. This is used very frequently when debugging and we don't know which pass could cause a particular change