[Bugfix][Transform] Keep private non-primitive functions in FuseTIR #16565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, private non-primitive relax functions would be discarded by `FuseTIR`. If any calls to these functions exist, the resulting `IRModule` would be ill-formed. This commit updates `FuseTIR` so that it only applies updates to functions with `attr::kPrimitive`, and calls into those functions. To retain backwards compatibility, `DeadCodeElimination` is applied as a post-processing step.
|
cc @Hzfengsy |
Hzfengsy
approved these changes
Feb 14, 2024
Lunderberg
deleted the
bugfix_fusetir_preserve_private_relax_functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, private non-primitive relax functions would be discarded by
FuseTIR. If any calls to these functions exist, the resultingIRModulewould be ill-formed. This commit updatesFuseTIRso that it only applies updates to functions withattr::kPrimitive, and calls into those functions.To retain backwards compatibility,
DeadCodeEliminationis applied as a post-processing step.