Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Windows CMake Command #16656

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

remkade
Copy link
Contributor

@remkade remkade commented Feb 29, 2024

This sets the arguments recommended previously in the docs as the default windows build args for the cmake generate step.

Instead of needing to say:

cmake -A x64 -Thost=x64 ..

Its now the same as linux and mac:

cmake ..

This sets the arguments recommended previously in the docs as the
default windows build args for the cmake generate step.

Instead of needing to say:

```bash
cmake -A x64 -Thost=x64 ..
```

Its now the same as linux and mac:

```bash
cmake ..
```
@tqchen tqchen merged commit 880af30 into apache:main Mar 4, 2024
19 checks passed
@remkade remkade deleted the remkade/simplify-windows-cmake branch March 4, 2024 16:37
Lunderberg pushed a commit to Lunderberg/tvm that referenced this pull request Mar 12, 2024
This sets the arguments recommended previously in the docs as the
default windows build args for the cmake generate step.

Instead of needing to say:

```bash
cmake -A x64 -Thost=x64 ..
```

Its now the same as linux and mac:

```bash
cmake ..
```
thaisacs pushed a commit to thaisacs/tvm that referenced this pull request Apr 3, 2024
This sets the arguments recommended previously in the docs as the
default windows build args for the cmake generate step.

Instead of needing to say:

```bash
cmake -A x64 -Thost=x64 ..
```

Its now the same as linux and mac:

```bash
cmake ..
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants