[Debug][Disco] Check if a PackedFunc exists before calling it #16845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, attempting to execute the result of `sess.get_global_func` for a non-existing function name would result in a segfault. While the equivalent `tvm.get_global_func` can throw an exception when looking up the function, Disco returns a `DFunction` immediately. This `DFunction` may resolve to a null pointer, and should be checked in the worker process before calling it.
vinx13
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, attempting to execute the result of
sess.get_global_funcfor a non-existing function name would result in a segfault. While the equivalenttvm.get_global_funccan throw an exception when looking up the function, Disco returns aDFunctionimmediately. ThisDFunctionmay resolve to a null pointer, and should be checked in the worker process before calling it.