[Relax] Enhance symbolic expr estimation in memory planning #16872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enhances the symbolic expression upper bound estimation in static memory planning. Prior to this PR, we are not able to estimate the upper bound of `a * b` when `a` has an upper bound while `b` does not. This PR enhances the estimation with arith::IntSet. We introduce another TIR attribute `tir_non_negative_var` to indicate the non-negative TIR variables for memory planning use. A new unit test is introduced for this enhancement.
MasterJH5574
force-pushed
the
tvm-dev/2024-04-11-mem-plan-symbolic
branch
from
7847d74 to
958ca0c
Compare
tqchen
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the symbolic expression upper bound estimation in static memory planning.
Prior to this PR, we are not able to estimate the upper bound of
a * bwhenahas an upper bound whilebdoes not. This PR enhances the estimation with arith::IntSet.We introduce another TIR attribute
tir_non_negative_varto indicate the non-negative TIR variables for memory planning use.A new unit test is introduced for this enhancement.