[TIR][Analyzer] Simplify x==x
expressions for all dtypes
#17158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there was no rule to simplify
x == x
intoTrue
. In some cases, despite not having an explicit rewrite rule inRewriteSimplifier
, theRewriteSimplifier::CanProve
function would check ifx-x
simplifies to zero, relying on the rewrite rules used fortir::Sub
. However, the rule to rewritex-x
into zero was only enabled forint32
,int64
, and floating-point types, so relying on this behavior was inconsistent.This commit updates the rewrite rules for both
tir::EQ
andtir::Sub
to check for simplification ofx-x
orx==x
, regardless of the datatype. This change preserves the fast-path for index data-types, in whichint32
andint64
expressions may be simplified without checking for side effects. For all other dtypes, the cancellation only applies when evaluatingx
has no side effects.