[Codegen] Emit tir::Let as var assignment explicitly
#17278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
force-pushed
the
tvm-dev/2024-08-16-codegen-let
branch
2 times, most recently
from
cf3217f to
5457abb
Compare
Prior to this PR, the PrimExpr `tir::Let` is treated as inlining during codegen, which makes any common subexpression elimination (CSE) efforts using `tir::Let` at TIR level effectless. This PR updates codegen so that the `tir::Let` will have an explicit var assignment and thus can effectively reflect the CSE efforts.
MasterJH5574
force-pushed
the
tvm-dev/2024-08-16-codegen-let
branch
from
5457abb to
8d7dad2
Compare
|
@tvm-bot rerun |
tqchen
approved these changes
Aug 21, 2024
|
I'm a little bit late on the review, but I like the fix, thank you! I double-checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the PrimExpr
tir::Letis treated as inlining during codegen, which makes any common subexpression elimination (CSE) efforts usingtir::Letat TIR level effectless.This PR updates codegen so that the
tir::Letwill have an explicit var assignment and thus can effectively reflect the CSE efforts.