[CODEGEN][CUDA] Fix global barrier #2473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI has some issue with Rust, check the slack |
vinx13
force-pushed
the
fix/cuda_global_barrier
branch
from
f8f0c30 to
04a1a92
Compare
|
According to https://discuss.tvm.ai/t/codegen-cuda-bug-in-global-barrier/1496/10, this might not be the right fix. Closed this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen for global barrier is wrong, see discussion in https://discuss.tvm.ai/t/codegen-cuda-bug-in-global-barrier/1496
please review @masahi