Add fallback for ApplyGraphBest #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
force-pushed
the
FixApplyGraphBestForDense
branch
from
86c5ad1 to
271ecb3
Compare
merrymercy
reviewed
Jan 28, 2019
| "A fallback configuration is used, which may bring great performance " \ | ||
| "regression." % (target, workload) | ||
| logger.warning(msg) | ||
| cfg = FallbackConfigEntity() |
There was a problem hiding this comment.
We can store this config in self._global_cfg_dict as we do in https://github.com/dmlc/tvm/blob/271ecb31a01e2b05d87e0c759bec42032d2d10d0/python/tvm/autotvm/task/dispatcher.py#L367-L369. So all latter changes and querys will be directed to this config.
Then we don't need the changes in the topi/python/topi/x86/nn.py
kevinthesun
force-pushed
the
FixApplyGraphBestForDense
branch
from
271ecb3 to
0641f55
Compare
|
@merrymercy Modified. |
merrymercy
approved these changes
Jan 30, 2019
|
@merrymercy please feel free to use your committer permission to merge the code as per https://docs.tvm.ai/contribute/committer_guide.html |
libing4752
pushed a commit
to libing4752/tvm
that referenced
this pull request
Feb 18, 2019
merrymercy
pushed a commit
to merrymercy/tvm
that referenced
this pull request
Feb 18, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallback for ApplyGraphBest to allow using default schedule for dense.
@merrymercy @icemelon9