Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY] TextPrinter: Use Map Format #2553

Merged
merged 2 commits into from
Feb 3, 2019
Merged

[RELAY] TextPrinter: Use Map Format #2553

merged 2 commits into from
Feb 3, 2019

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Feb 2, 2019

Copy link
Contributor

@wweic wweic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. A minor comment.

@@ -46,7 +46,7 @@ inline std::ostream& operator<<(std::ostream& os, const TextValue& val) { // NO
* Each element in the meta-data section can be referenced by the text format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the comment at line 45 as well.

@tqchen tqchen merged commit e0af5c2 into apache:master Feb 3, 2019
libing4752 pushed a commit to libing4752/tvm that referenced this pull request Feb 18, 2019
merrymercy pushed a commit to merrymercy/tvm that referenced this pull request Feb 18, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@yzhliu yzhliu mentioned this pull request Mar 2, 2019
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants