-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[relay][frontend] TensorFlow saved model support #2586
Conversation
7f8119e
to
8671af9
Compare
"""A Wrapper to handle tensorflow models parsing | ||
TensorFlow is needed | ||
``` | ||
parser = TfParser(model_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: move this code to an example section?
Examples
.. code-block:: python
parser = TfParser(model_dir)
graph = parser.parse()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, thx. BTW, backslash like "\----------" could help avoid markdown parsing
could you please help review it when you have a chance? @srkreddy1238 |
Look good to me except that the tensorflow_parser is same for both NNVM and relay. |
@yongwww please update per comment. @srkreddy1238 please try to ping the contributor next time in case ppl forget |
ping @yongwww |
@tqchen I am working on it, will update it later today. Sorry I was working on something else and was in TensorFlow dev summit 2019 the past week. |
@srkreddy1238 Just keep one copy of tensorflow_parser in relay, please take another look. |
Thanks @yongwww. Also suggest to consider adding a test case or (and) a tutorial to demonstrate (& protect) TFParser use case later after this PR. |
@srkreddy1238 Thanks! Sure I'll do that. I am working on another PR to add more ops mapping in tf frontend, such as Gather, Exp, etc. |
@srkreddy1238 conflict solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yongwww LGTM
* [relay][frontend] TensorFlow saved model support * Add Examples section * keep one copy of tensorflow_parser in relay
* [relay][frontend] TensorFlow saved model support * Add Examples section * keep one copy of tensorflow_parser in relay
Add TF saved model support in relay tf frontend, infer shape w/o add_shapes=True.
Please help take a look. @srkreddy1238 @yzhliu @zhiics