Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay][frontend] TensorFlow saved model support #2586

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

yongwww
Copy link
Member

@yongwww yongwww commented Feb 11, 2019

Add TF saved model support in relay tf frontend, infer shape w/o add_shapes=True.
Please help take a look. @srkreddy1238 @yzhliu @zhiics

@yongwww yongwww force-pushed the relay_tf branch 4 times, most recently from 7f8119e to 8671af9 Compare February 12, 2019 18:31
"""A Wrapper to handle tensorflow models parsing
TensorFlow is needed
```
parser = TfParser(model_dir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: move this code to an example section?

Examples

.. code-block:: python
    parser = TfParser(model_dir)
    graph = parser.parse()

Copy link
Member Author

@yongwww yongwww Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, thx. BTW, backslash like "\----------" could help avoid markdown parsing

@yongwww
Copy link
Member Author

yongwww commented Feb 20, 2019

could you please help review it when you have a chance? @srkreddy1238

@srkreddy1238
Copy link
Contributor

Look good to me except that the tensorflow_parser is same for both NNVM and relay.
Consider keeping one copy and use across NNVM and relay. Practice so far was to keep under relay and use it in NNVM.

@tqchen tqchen added the status: need update need update based on feedbacks label Feb 23, 2019
@yzhliu yzhliu mentioned this pull request Mar 2, 2019
28 tasks
@tqchen
Copy link
Member

tqchen commented Mar 3, 2019

@yongwww please update per comment. @srkreddy1238 please try to ping the contributor next time in case ppl forget

@tqchen
Copy link
Member

tqchen commented Mar 9, 2019

ping @yongwww

@yongwww
Copy link
Member Author

yongwww commented Mar 10, 2019

@tqchen I am working on it, will update it later today. Sorry I was working on something else and was in TensorFlow dev summit 2019 the past week.

@yongwww
Copy link
Member Author

yongwww commented Mar 10, 2019

@srkreddy1238 Just keep one copy of tensorflow_parser in relay, please take another look.

@srkreddy1238
Copy link
Contributor

Thanks @yongwww.
Just resolve the conflicts & we are good to go.

Also suggest to consider adding a test case or (and) a tutorial to demonstrate (& protect) TFParser use case later after this PR.

@yongwww
Copy link
Member Author

yongwww commented Mar 10, 2019

@srkreddy1238 Thanks! Sure I'll do that. I am working on another PR to add more ops mapping in tf frontend, such as Gather, Exp, etc.

@yongwww
Copy link
Member Author

yongwww commented Mar 11, 2019

@srkreddy1238 conflict solved

Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yongwww LGTM

@srkreddy1238 srkreddy1238 merged commit f7eff09 into apache:master Mar 11, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
* [relay][frontend] TensorFlow saved model support

* Add Examples section

* keep one copy of tensorflow_parser in relay
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
* [relay][frontend] TensorFlow saved model support

* Add Examples section

* keep one copy of tensorflow_parser in relay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need review status: need update need update based on feedbacks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants