-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix]Revert PR #2420 cuda/nms changes #2747
Conversation
Can you add unit tests for that fix? |
nms unit tests already exits. The bug only happens for mali rk3399 and I don't think they have it in CI (correct me if I'm wrong.) |
Can we add unit test for |
@Laurawly do you have idea why this caused error? |
Sort_ir is included in nms op. It's not yet separated as a single op. Again this case will only fail on certain mali GPUs. |
According to discussion forum: https://discuss.tvm.ai/t/mali-cl-out-of-resources-error-for-mxnet-ssd-models/1863. Found the bug caused by PR #2420's cuda/nms.py change. Reverting it back. @apivovarov