[Relay] InferCorrectLayout for strided_slice & min_num_branches option in CombineParallelConv2D #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
force-pushed
the
feature/strided_slice_alter
branch
from
4dd40d1 to
bd1b8a0
Compare
vinx13
changed the title
yzhliu
reviewed
Apr 7, 2019
vinx13
force-pushed
the
feature/strided_slice_alter
branch
from
89798fd to
1517d5f
Compare
yzhliu
approved these changes
Apr 9, 2019
|
Thanks! @vinx13 |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 10, 2019
…n in CombineParallelConv2D (apache#2961) * [Relay] InferCorrectLayout for strided_slice * Add min_num_branches option to CombineParallelConv2D * Return undef if original layout contains splitted axes
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 11, 2019
…n in CombineParallelConv2D (apache#2961) * [Relay] InferCorrectLayout for strided_slice * Add min_num_branches option to CombineParallelConv2D * Return undef if original layout contains splitted axes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AlterOpLayout, rewrite attributes of strided_slice if packed layout (e.g. NCHW4c) is used. Thebeginandendare divided by the factor of sub-axis.This allows the expression after
CombineParallelConv2Dtransformation to use packed layout.An option
min_num_branchesis added toCombineParallelConv2Dto control when to apply the pass according to performance issue in #2827cc @masahi @kevinthesun @yzhliu