Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TF get_output_names #3025

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Simplify TF get_output_names #3025

merged 1 commit into from
Apr 16, 2019

Conversation

apivovarov
Copy link
Contributor

  • replaced keys() + get(k)' with values()`
  • removed unnecessary set-to-list conversion

@yongwww
Copy link
Member

yongwww commented Apr 15, 2019

cc @srkreddy1238 @zhiics

yongwww
yongwww approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apivovarov
Copy link
Contributor Author

@yzhliu Could you review and merge this PR?

@tqchen tqchen merged commit 2b24e23 into apache:master Apr 16, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
@apivovarov
Simplify TF get_output_names (apache#3025)
c68b39f
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
@apivovarov @wweic
Simplify TF get_output_names (apache#3025)
c9798ad
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongwww yongwww yongwww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apivovarov @yongwww @tqchen