[codegen] heterogeneous build for c++ #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhiics I just merged @antinucleon's PR updating the build function. It looks like there are conflicts, but it would be great to integrate the two. I would like to minimize the amount of time we have two different code paths. |
|
@jroesch Sure. Let me act on integrating them. |
zhiics
force-pushed
the
heterogeneous_build
branch
from
5b68e90 to
ce5b485
Compare
|
cc @antinucleon |
antinucleon
reviewed
May 8, 2019
Closed
|
@zhiics Do you have interest to replace python build_module? I think we have all functions ready (may need to polish scope functions) |
zhiics
force-pushed
the
heterogeneous_build
branch
from
f1c3715 to
13798a8
Compare
|
@antinucleon Sure. I can work on it. But that should be a separate PR. |
antinucleon
reviewed
May 9, 2019
|
LGTM. I suggest to add/modify current test to fp16, as we have seen a few times around building system with fp16. |
antinucleon
approved these changes
May 9, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* heterogeneous build for c++ * merge relay buildmodule to codegen build * use module split * use target_host * remove sse3 * retrigger ci
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* heterogeneous build for c++ * merge relay buildmodule to codegen build * use module split * use target_host * remove sse3 * retrigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have python version of heterogeneous build. This PR is to make the C++ build support code generation for heterogeneous platform. Therefore, we can use codegen for different cases directly in C++ instead of invoking it from Python through
PackedFunc.@tqchen @yzhliu @jroesch @icemelon9 @masahi @wweic