[Rust] Static syslib #3274
Merged
[Rust] Static syslib #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
approved these changes
Jun 5, 2019
jroesch
reviewed
Jun 5, 2019
| use tvm_runtime::DLTensor; | ||
|
|
||
| mod tvm_mod { | ||
| import_module!("runtime/tests/test_tvm_static/test.o"); |
There was a problem hiding this comment.
Is there a way to have this generate better wrappers for the contained packed functions, instead of having to use macros to call them?
There was a problem hiding this comment.
What did you have in mind? The only other alternative would be to have build.rs dump the macro output to a file (or write a compiler plugin, but that's the nuclear option).
|
Please help to resolve the CI problem http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3274/2/pipeline |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a macro that loads syslib modules at compile time. The immediate benefit is that it removes the need for closures. This macro will later be expanded to instantiate graphs at compile time.
cc @ehsanmok