[Autotvm] Support override in register_topi_compute and register_topi_schedule #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlu1
force-pushed
the
override
branch
2 times, most recently
from
5f3ad9a to
60b03a9
Compare
|
Looks good to me. |
ajtulloch
approved these changes
Jun 6, 2019
merrymercy
approved these changes
Jun 7, 2019
|
The unit test I added (override dense autotvm schedules) originally seemed to interfere with the test environment and was causing the CI to fail. Removing it fixed the CI. |
|
@merrymercy feel free to merge it as you are managing the PR and has the write access |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting override in register_topi_compute and register_topi_schedule allows developers to experiment with different implementation locally, which can help improve dev efficiency.
@merrymercy and @tqchen, please review.