[CI] Clarify RAT exclude patterns. #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that the original rat is relatively simpler and perhaps ignores only a bit more. I incline to keep the original pattern, so when users check manually with rat we won't get as long messages |
|
@tqchen are you commenting on the first or second patch here? |
tqchen
requested changes
Jun 10, 2019
tests/scripts/task_lint.sh
Outdated
| # their position on the directory tree we use a secondary mechanism | ||
| # that can match patterns across / seperators. | ||
| cat > /tmp/$$.ignore-re.txt <<EOF | ||
| == File: \./jvm/[^/]*/[^/]*/target/.* |
There was a problem hiding this comment.
specifically, these additional ignore patterns seem complicates the checking process. It would be great to keep the original rat-exclude patterns without having to check in here
There was a problem hiding this comment.
Revised with two new patterns in rat-exclude for jvm and tutorials.
RAT exclude patterns are not matched across path separators. Patterns of the form xyz/* will match files and directories named xyz anywhere in the tree because the regexp /* contracts to "". Adjust the existing rat exclude patterns that appear to contain matches with path separators to be explicit about the pattern they actually match.
The build process generates artificats into jvm/../targets and docs/../tutorials subdirectories, many of which trigger RAT. RAT exclude syntax does not match path separators so it is not possible to target specific built directories. This patch tells RAT to ignore and file or directory named 'jvm' and 'tutorials' irrespective of where they are located. This choice is conservative, and may result in source files being ingored from the RAT scan.
|
Thanks @mshawcroft |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAT exclude patterns are not matched across path separators. Patterns
of the form xyz/* will match files and directories named xyz anywhere
in the tree because the regexp /* contracts to "". Adjust the
existing rat exclude patterns that appear to contain matches with path
separators to be explicit about the pattern they actually match.