-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QNN] Multiplication operator #3927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please feel free to ping me for any QNN related PRs :)
I have a concern about the lowering.
* \param arg_types The types of input and output. | ||
* \return The sequence of Relay ops for mul op. | ||
*/ | ||
Expr QnnMulCanonicalize(const Attrs& attrs, const Array<Expr>& new_args, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that there is a mistake in the lowering. Can you please provide description of how the lowering instructions are decided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that there is a mistake in the lowering. Can you please provide description of how the lowering instructions are decided?
Same as the addition operator - only difference is that the requantized tensors are multiplied to provide the output. Let me know which part of the instructions you see an issue with and I'll take a closer look - Thanks
@tristan-arm @anijain2305 please followup on this thread :) |
@tristan-arm Sorry for the huge delay. This is what the lowering should look like. Let me know what do you think about this.
|
ping @tristan-arm please follow up :) |
thanks @u99127 @tristan-arm @anijain2305 |
Implementation of the qnn multiplication operator following the same pattern as the addition operator.