[ROCM] Working math function support for ROCm backend, a bug fix in LLVM based codegen #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @adityaatluri |
masahi
changed the title
lint fix fix build bug fix extern func call in llvm based codegen
tqchen
reviewed
Oct 20, 2017
src/codegen/llvm/intrin_rule_rocm.cc
Outdated
| using namespace ir; | ||
| const Call* call = e.as<Call>(); | ||
| CHECK(call != nullptr); | ||
| const std::string bit_width = std::to_string(call->type.bits()); |
There was a problem hiding this comment.
it might be easier to use std::ostringstream to construct the string
There was a problem hiding this comment.
specifically use
std::ostringstream intrin_name;
intrin_name << "__ocml_" << call->name << "_f" << call->type.bits();
// use intrin_name.str()
tqchen
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds working math function support to ROCm backend. It supersedes #553.
It also fixes a bug in external function call generator in LLVM based codegen.
With this PR, we can pass test_topi_softmax.py and test_topi_reduce.py.
It also enables running resnet and mobilenet benchmark in nnvm.
Resnet18 and mobilenet benchmark, on R9 Nano