-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKPORT-0.6][Bugfix][Arith] keep div_mode during floordiv simplify #5922
Conversation
Thanks @yzhliu , seems we need a different testcase, that uses a truncdiv but still triggers DivModeCompatibleTo |
@yzhliu : The original issue is fixed indeed, Thanks! --> expr = (((x0 - floordiv((0 - (x15)), 2)) - 1) + floordiv((37 + ((x1 + 7)-5)), 2)) |
@tqchen, @yzhliu : I have one concern here(However not related to this PR). should be evaluated to actually but with current simplify stage(rewrite_simplify + canonical_simplify), it evaluates to below: But when i run stages as (rewrite_simplify + canonical_simplify + rewrite_simplify) it evaluates perfectly to x0. So may be we need to run these stages with some customized config every time or until there are no more changes? |
@ANSHUMAN87 good catch, this is what the argument |
692be9c
to
c8b43c8
Compare
@yzhliu please also send a patch to v0.6 |
c8b43c8
to
6240c55
Compare
6240c55
to
d818f05
Compare
@tqchen @sergei-grechanik please take a look.