Add cloudpickle dependency to docker images #6701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
force-pushed
the
cloudpickle
branch
from
ed8295a to
c435b4b
Compare
|
The dependency added looks good to me. Just wondering if the cmake source build is necessary? Alternatively, we can pip install a newer cmake. WDYT? |
tqchen
approved these changes
Oct 18, 2020
|
Thanks @tkonolige @junrushao1994 I think cmake from source makes sense here because pip cmake is a bit unconventional. This is merged. I will send an updated note when the binary tags get updated. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is needed for #6679. I also had to add a cmake build from source to the i386 image so that xgboost builds (it builds from source because there is no wheel for i386).
@jroesch @tqchen