Fix bug of generate-unmatched-brackets in CodeGenC::PrintSSAAssign #6887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Light-of-Hers , can you enhance the code to still remove extra brackets if they match? The idea would be to add a CheckBracketMatch code that scans the string and use counter to check if the two bracket indeed matches each other (and remove if they do) |
Light-of-Hers
force-pushed
the
crz/dev
branch
from
276467b to
795e5e7
Compare
|
Updated @tqchen |
tqchen
requested changes
Nov 10, 2020
|
Sorry, some low-level mistakes😂. Is it okay now? @tqchen |
tqchen
approved these changes
Nov 10, 2020
|
Thanks @Light-of-Hers ! |
tqchen
added
status: accepted
and removed
status: need update
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug discussed in #6884 @tqchen