[AutoScheduler] Misc update to hardware parameter and task scheduler #7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jcf94 |
merrymercy
changed the title
FrozenGene
reviewed
Dec 3, 2020
Comment on lines
+48
to
+52
| int max_shared_memory_per_block; | ||
| /*! \brief The max number of register per block. */ | ||
| int max_registers_per_block; | ||
| /*! \brief The max number of threads per block. */ | ||
| int max_threads_per_block; |
There was a problem hiding this comment.
How about exposing them under the tvm/_ffi/runtime_ctypes.py like
@property
def max_thread_dimensions(self):This will bring convenience when we want to get these values in our HardwareParams like (mali target)
There was a problem hiding this comment.
This is already supported by VisitAttrs
There was a problem hiding this comment.
What I meant is we add code wrapper using attr like this:
@property
def max_registers_per_block(self):
"""Return max registers per block"""
return self._GetDeviceAttr(self.device_type, self.device_id, 9)Otherwise we access these property will not be convenient like other property max_shared_memory_per_block supported before.
There was a problem hiding this comment.
This is irrelevant to this PR.
We can do it in other PRs.
There was a problem hiding this comment.
Please take another look and approve. Thanks!
FrozenGene
approved these changes
Dec 3, 2020
merrymercy
force-pushed
the
pr-hardware-param
branch
from
f3d7312 to
4ff36bd
Compare
merrymercy
force-pushed
the
pr-hardware-param
branch
from
4ff36bd to
d561662
Compare
merrymercy
commented
Dec 3, 2020
merrymercy
commented
Dec 3, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
…pache#7020) * [AutoScheduler] Mics update to hardware parameter and task scheduler * update * update * update * update * fix * fix * update * improve warning message * update * lint * update * update * fix * Apply suggestions from code review * trigger CI
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
…pache#7020) * [AutoScheduler] Mics update to hardware parameter and task scheduler * update * update * update * update * fix * fix * update * improve warning message * update * lint * update * update * fix * Apply suggestions from code review * trigger CI
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…pache#7020) * [AutoScheduler] Mics update to hardware parameter and task scheduler * update * update * update * update * fix * fix * update * improve warning message * update * lint * update * update * fix * Apply suggestions from code review * trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogEstimatedLatencyto the default callback list in task scheduler.