-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELAY,TOPI] Threefry PRNG: splittable and stateless #7083
Changes from 13 commits
975d5e7
c87658b
4c230fe
eaf07d6
d858d5e
abe300b
54a7de0
6694be3
374e944
ee949a7
930282f
ed30d60
ed59bfb
9c4ac11
e3e8af2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/*! | ||
* \file tvm/relay/attrs/vision.h | ||
* \brief Auxiliary attributes for random operators. | ||
*/ | ||
#ifndef TVM_RELAY_ATTRS_RANDOM_H_ | ||
#define TVM_RELAY_ATTRS_RANDOM_H_ | ||
|
||
#include <tvm/ir/attrs.h> | ||
|
||
namespace tvm { | ||
namespace relay { | ||
|
||
struct ThreefryGenerateAttrs : public tvm::AttrsNode<ThreefryGenerateAttrs> { | ||
Array<Integer> out_shape; | ||
|
||
TVM_DECLARE_ATTRS(ThreefryGenerateAttrs, "relay.attrs.ThreefryGenerateAttrs") { | ||
TVM_ATTR_FIELD(out_shape).describe("Shape of random numbers to generate"); | ||
} | ||
}; | ||
|
||
} // namespace relay | ||
} // namespace tvm | ||
#endif // TVM_RELAY_ATTRS_RANDOM_H_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
# pylint: disable=wildcard-import | ||
"""PRNG related operators.""" | ||
from .kernel import * | ||
from . import _kernel |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""Splittable and parallelizable PRNG kernels.""" | ||
# pylint: disable=invalid-name,unused-argument | ||
from __future__ import absolute_import | ||
|
||
from .. import strategy | ||
from ..op import register_strategy, register_pattern, OpPattern | ||
|
||
|
||
# Threefry | ||
register_strategy("random.threefry_generate", strategy.threefry_generate_strategy) | ||
register_pattern("random.threefry_generate", OpPattern.OPAQUE) | ||
register_strategy("random.threefry_split", strategy.threefry_split_strategy) | ||
register_pattern("random.threefry_split", OpPattern.OPAQUE) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""Constructor APIs""" | ||
import tvm._ffi | ||
|
||
tvm._ffi._init_api("relay.op.random._make", __name__) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""Splittable and parallelizable PRNG kernels.""" | ||
# pylint: disable=invalid-name,unused-argument | ||
from __future__ import absolute_import | ||
|
||
import sys | ||
import numpy as np | ||
|
||
from ...expr import Constant | ||
from .... import nd | ||
from . import _make | ||
|
||
|
||
def threefry_key(seed): | ||
"""Create a new Threefry random number generator key. | ||
Example | ||
------- | ||
.. code-block:: python | ||
gen = threefry_key(0) | ||
_, random_number = threefry_generate(gen, (4,)) | ||
Parameters | ||
---------- | ||
seed : int | ||
Starting seed for the key | ||
Returns | ||
------- | ||
key : relay.Expr | ||
New key to pass to future uses of :py:func:`threefry_split` or | ||
:py:func:`threefry_generate`. | ||
""" | ||
s = np.frombuffer(seed.to_bytes(32, sys.byteorder), dtype="uint64") | ||
a = np.concatenate((s, np.array([0, 0, 0, 0, 1 << 63, 0], dtype="uint64"))) | ||
return Constant(nd.array(a)) | ||
|
||
|
||
def threefry_generate(key, shape): | ||
"""Generate an array of random bits (`uint64`) using the Threefry algorithm | ||
Example | ||
------- | ||
.. code-block:: python | ||
key = threefry_key(0) | ||
new_key, random1 = threefry_generate(key, (4,)) | ||
_, random2 = threefry_generate(new_key, (4,)) | ||
# random1 and random2 are different random numbers | ||
Parameters | ||
---------- | ||
key : relay.Expr | ||
key that uniquely determines the random values. Multiple uses with the | ||
same key will generate the same random values. This key should be | ||
treated as an opaque pointer. You can create one from calling | ||
:py:func:`threefry_key`, :py:func:`threefry_split`, or | ||
:py:func:`threefry_generate`. **Do not use this key again after calling | ||
this function.** | ||
shape : Sequence[int] | ||
Desired outputs shape of random numbers. **Currently the total | ||
number of elements must be a multiple of 4.** | ||
Returns | ||
------- | ||
new_key : relay.Expr | ||
New key to pass to future uses of :py:func:`threefry_split` or | ||
:py:func:`threefry_generate`. | ||
random_array : relay.Expr | ||
Array of random numbers. Has shape `shape`. | ||
""" | ||
return _make.threefry_generate(key, shape) | ||
|
||
|
||
def threefry_split(key): | ||
"""Split an existing Threefry key into two new ones. | ||
This is useful if you have to subsequent calls which each need their own | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why wouldn't someone just create two separate three fry keys using different seeds, and use them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Creating separate keys has not been theoretically proven to be as random as splitting a single key. Maybe I should add a comment that you should only really create one key. On the other hand, these details might be better handled at a higher level interface (future work). |
||
independent random number generation. | ||
Example | ||
------- | ||
.. code-block:: python | ||
def foo(key): | ||
new_key, num = threefry_generate(key, (4,)) | ||
return num | ||
key = threefry_key(0) | ||
key1, key2 = threefry_split(key) | ||
assert foo(key1) != foo(key2) | ||
Parameters | ||
---------- | ||
key : relay.Expr | ||
key that uniquely determines the random values. Multiple uses with the | ||
same generator will generate the same random values. This generator should be | ||
treated as an opaque pointer. You can create one from calling | ||
:py:func:`threefry_key`, :py:func:`threefry_split`, or | ||
:py:func:`threefry_generate`. **Do not use this generator again after calling | ||
this function.** | ||
Returns | ||
------- | ||
new_key_1 : relay.Expr | ||
New key to pass to future uses of :py:func:`threefry_split` or | ||
:py:func:`threefry_generate`. | ||
new_key_2 : relay.Expr | ||
New key to pass to future uses of :py:func:`threefry_split` or | ||
:py:func:`threefry_generate`. | ||
""" | ||
return _make.threefry_split(key) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# pylint: disable=wildcard-import | ||
"""Pseudorandom generator kernels and operators.""" | ||
from __future__ import absolute_import | ||
|
||
from .kernel import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the total number of outputs need to be a multiple of four?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an implementation detail. Basically, threefry uses 4 64-bit words as its state, inputs, and outputs.