-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MaybeAlign to CreateAtomicRMW calls to fix build for LLVM13 #7578
Conversation
I can't really see what's going wrong in the build. Perhaps it's using an older version of LLVM which is not compatible with these changes? |
Yes probably you need ifdef for llvm 11. |
I found out that I wasn't actually using LLVM 11.0.0, but a newer version (13.0.0), as I cloned it from Git. Apparently, a change was made there recently (llvm/llvm-project@24539f1) which altered the CreateAtomicRMW behaviour. I added |
@Luuk- Can you try retrigger the CI test (fetch and rebase against main)? It seems CI is stuck for some reason. |
@Luuk- please check your diff, probably you merged upstream changes, you need to rebase |
Sorry, should be fixed now. CI still seems stuck. There isn't an action I should perform in the Jenkins environment to trigger or schedule the CI test, or is there...? |
No, there is not. |
Strange that it is still stuck. @masahi, do you have any ideas how to proceed from here? |
hmm strange, maybe try again? |
I don't see any record of Jenkins seeing this PR. maybe a GH problem or a problem that occurred 5 days ago when the PR was made? I can't see that far back in the pipeline log. |
I didn't encounter an error when creating the PR, as far as I know. I could try to close this PR and open a new one. Would you suggest that? |
yeah let's try that |
See issue #7576
Fixes build for me on Win10.
@masahi