Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MaybeAlign to CreateAtomicRMW calls to fix build for LLVM13 #7578

Closed
wants to merge 2 commits into from

Conversation

Luuk-
Copy link

@Luuk- Luuk- commented Mar 3, 2021

See issue #7576
Fixes build for me on Win10.

@masahi

@Luuk- Luuk- marked this pull request as ready for review March 3, 2021 12:26
@Luuk-
Copy link
Author

Luuk- commented Mar 3, 2021

I can't really see what's going wrong in the build. Perhaps it's using an older version of LLVM which is not compatible with these changes?

@masahi
Copy link
Member

masahi commented Mar 3, 2021

Yes probably you need ifdef for llvm 11.

@Luuk-
Copy link
Author

Luuk- commented Mar 3, 2021

I found out that I wasn't actually using LLVM 11.0.0, but a newer version (13.0.0), as I cloned it from Git. Apparently, a change was made there recently (llvm/llvm-project@24539f1) which altered the CreateAtomicRMW behaviour. I added #if now for LLVM13. I would expect this to work, as it also works locally.

@masahi
Copy link
Member

masahi commented Mar 4, 2021

@Luuk- Can you try retrigger the CI test (fetch and rebase against main)? It seems CI is stuck for some reason.

@masahi
Copy link
Member

masahi commented Mar 4, 2021

@Luuk- please check your diff, probably you merged upstream changes, you need to rebase

@Luuk- Luuk- force-pushed the build-llvm11-fix branch from b12275e to 6c852a9 Compare March 4, 2021 10:28
@Luuk-
Copy link
Author

Luuk- commented Mar 4, 2021

Sorry, should be fixed now. CI still seems stuck. There isn't an action I should perform in the Jenkins environment to trigger or schedule the CI test, or is there...?

@masahi
Copy link
Member

masahi commented Mar 4, 2021

No, there is not.

@Luuk-
Copy link
Author

Luuk- commented Mar 8, 2021

Strange that it is still stuck. @masahi, do you have any ideas how to proceed from here?

@masahi
Copy link
Member

masahi commented Mar 8, 2021

hmm strange, maybe try again?

@Luuk- Luuk- force-pushed the build-llvm11-fix branch from 6c852a9 to 900544e Compare March 8, 2021 16:30
@Luuk- Luuk- changed the title Added MaybeAlign to CreateAtomicRMW calls to fix build for LLVM11 Added MaybeAlign to CreateAtomicRMW calls to fix build for LLVM13 Mar 8, 2021
@masahi
Copy link
Member

masahi commented Mar 9, 2021

@tqchen @areusch any idea why CI is stuck with this PR? It's being stuck like this for three times in a row.

@areusch
Copy link
Contributor

areusch commented Mar 9, 2021

I don't see any record of Jenkins seeing this PR. maybe a GH problem or a problem that occurred 5 days ago when the PR was made? I can't see that far back in the pipeline log.

@LuukOddity
Copy link
Contributor

I didn't encounter an error when creating the PR, as far as I know. I could try to close this PR and open a new one. Would you suggest that?

@masahi
Copy link
Member

masahi commented Mar 9, 2021

yeah let's try that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants