[SPIRV] Minor update to TIR sort to make it work on VK/SPIR-V #7607
Conversation
|
When I was developing this, I noticed that implicitly allocating the start/middle/end variables, i.e. removing this line: |
|
seems everything is ok, ready to merge? @mbrookhart |
| @@ -75,7 +75,7 @@ def check_device(device): | |||
| f(tvm_data, tvm_out) | |||
| tvm.testing.assert_allclose(tvm_out.asnumpy(), np_sort, rtol=1e0) | |||
|
|
|||
| for device in ["llvm", "cuda", "opencl"]: | |||
| for device in ["llvm", "cuda", "opencl", "vulkan", "nvptx"]: | |||
There was a problem hiding this comment.
Thanks @masahi - in the case of vulkan here the tests won't be run until we add vulkan to our CI docker image, right? These are just tested locally?
There was a problem hiding this comment.
yes vulkan was tested locally, but not on CI.
|
@mbrookhart I found the reason why dynamic shape is not working #7620. We can merge this PR first and I can add a dynamic sort test in #7620. |
…#7607) * sort started to working * static size sort seems to be working * test sort on vulkan * add nvptx to sort test too
…#7607) * sort started to working * static size sort seems to be working * test sort on vulkan * add nvptx to sort test too
Didn't look into why but this change seems to make it possible to run TIR sort with VK/SPIR-V on static shape. Dynamic shapes on SPIR-V seem to have some issues in general.
Enabled TIR sort tests on vulkan.
@mbrookhart @tmoreau89 @jwfromm