Fix compilation errors with clang 11 #7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace llvm::MaybeAlign::MaybeAlign() with llvm::MaybeAlign(). - Use ICHECK instead of assert in hexagon_module.cc.
|
cc @LuukOddity please confirm if this still builds for you |
|
I used clang 11 to compile this, not as the source of LLVM libraries. I use LLVM trunk (i.e. the ToT main branch) for the code generation libraries, |
masahi
approved these changes
Apr 1, 2021
|
Thanks @kparzysz-quic |
|
Sorry for the late reply, I see it's already merged. Should I still check @masahi? |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
- Replace llvm::MaybeAlign::MaybeAlign() with llvm::MaybeAlign(). - Use ICHECK instead of assert in hexagon_module.cc.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
- Replace llvm::MaybeAlign::MaybeAlign() with llvm::MaybeAlign(). - Use ICHECK instead of assert in hexagon_module.cc.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
- Replace llvm::MaybeAlign::MaybeAlign() with llvm::MaybeAlign(). - Use ICHECK instead of assert in hexagon_module.cc.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
- Replace llvm::MaybeAlign::MaybeAlign() with llvm::MaybeAlign(). - Use ICHECK instead of assert in hexagon_module.cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::MaybeAlign::MaybeAlign()withllvm::MaybeAlign().ICHECKinstead ofassertin hexagon_module.cc.