[Relay] Add LowerTEPass into vm lowering proecss #9134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepapadim
requested review from
anijain2305,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
Hi @mikepapadim, my apologies but I don't quite understand what the impact of this change is as it appears to have no effect on any of the test cases - could you add some information to motivate the change? |
|
Just catching up after being out for a week -- is "vm_mod" used for anything other than name mangling? |
mbs-octoml
reviewed
Oct 1, 2021
|
|
||
| targets_ = GetTecTargetMapFromTargetMap(targets); | ||
|
|
||
| pass_seqs.push_back(tec::LowerTEPass(targets_, device_map, "vm_mod", [this](Function func) {})); |
There was a problem hiding this comment.
For others: This PR also needs to remove the direct calls to the TECompiler Lower and LowerShapeFunc which are a bit fiddly to change over. I believe Michalis is working on that.
|
What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
LowerTEPassin the VM compiler.@mbs-octoml @jroesch @electriclilies