Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Caffe Frontend] Add support for Permute layer #9157

Merged
merged 9 commits into from
Jan 13, 2022

Conversation

mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Sep 30, 2021

Added Permute layer support.
Related to #6206, #9060

@fernchen @zhiics @tqchen @FrozenGene
Can you take a look at this PR, please? Thanks!

@@ -586,6 +586,27 @@ def test_forward_LRN():
_test_lrn(data, local_size=3, alpha=2.0, beta=0.5, k=2.0)


#######################################################################
# Permute
# -----------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrozenGene
Sorry, can you specifically point out what's wrong with the code?
There seems to be no problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 590 and Line 591.

# Permute
# -------

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrozenGene
Thanks you very much.
I fixed it.

@mshr-h mshr-h requested a review from icemelon as a code owner November 8, 2021 12:42
@mshr-h
Copy link
Contributor Author

mshr-h commented Jan 5, 2022

Since #9060 was merged, tvm-ci/pr-merge should be passing correctly.

@masahi
Copy link
Member

masahi commented Jan 9, 2022

@mshr-h please take a look at the CI problem

@mshr-h
Copy link
Contributor Author

mshr-h commented Jan 13, 2022

hi @masahi thank you for your reply.
I re-run CI and everything has passed.

@masahi masahi merged commit 39758e7 into apache:main Jan 13, 2022
@mshr-h mshr-h deleted the caffe-permute-support branch January 13, 2022 01:16
crazydemo pushed a commit to crazydemo/tvm that referenced this pull request Jan 27, 2022
* Add support for Permute layer

* Add test for Permute layer

* Fix alignment
Raghav-Chakravarthy pushed a commit to Raghav-Chakravarthy/tvm that referenced this pull request Jan 28, 2022
* Add support for Permute layer

* Add test for Permute layer

* Fix alignment
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
* Add support for Permute layer

* Add test for Permute layer

* Fix alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants