[Support] Add libinfo into the runtime build #9310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mbrookhart! BTW, do we want to move libinfo.cc to somewhere under the runtime folder? |
|
We treat it as a separate object in cmake and extract it from the source tree at build time. Given the special treatment, I think support is a reasonable place? |
|
Got it. Then it looks good to me :-) |
junrushao
approved these changes
Oct 18, 2021
|
It looks like I broke something, let me figure out how |
mbrookhart
changed the title
|
Because only one of libtvm and libtvm_runtime is ever dlopened at a time, we need libinfo in both. |
mbrookhart
force-pushed
the
move_libinfo_to_runtime
branch
from
e43b4e9 to
731cb92
Compare
mbrookhart
force-pushed
the
move_libinfo_to_runtime
branch
from
731cb92 to
3fe0555
Compare
mbrookhart
requested review from
areusch,
liangfu,
manupak and
tmoreau89
as code owners
mbrookhart
force-pushed
the
move_libinfo_to_runtime
branch
from
3fe0555 to
c60dbee
Compare
mbrookhart
requested review from
comaniac,
icemelon,
jroesch,
tqchen,
yzhliu and
zhiics
as code owners
mbrookhart
force-pushed
the
move_libinfo_to_runtime
branch
from
14655fa to
f7455b5
Compare
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Nov 12, 2021
* main: (119 commits) [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336) Fix repository URL in ubuntu_install_rocm.sh (apache#9425) Add LLVM-13 installation to Docker setup (apache#9498) [Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499) Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442) [COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488) Add default for split op (apache#9489) [HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486) Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481) [Support] Add libinfo into the runtime build (apache#9310) Change Call with TIRCallAttrs to call_lowered op (apache#9312) [ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477) [CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480) [MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335) [microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470) Better host handling in CompilationConfig & debug printing (apache#9460) [AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271) [TIR] Add type hint for TIR (apache#9432) [TVMC] Add test for quantized pytorch model (apache#9467) [CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397) ...
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* Move libinfo into the runtime build * put libinfo back into libtvm * limit microtvm imports when we only have the runtime lib * fix lint * try conditional for micro import
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* Move libinfo into the runtime build * put libinfo back into libtvm * limit microtvm imports when we only have the runtime lib * fix lint * try conditional for micro import
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Move libinfo into the runtime build * put libinfo back into libtvm * limit microtvm imports when we only have the runtime lib * fix lint * try conditional for micro import
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* Move libinfo into the runtime build * put libinfo back into libtvm * limit microtvm imports when we only have the runtime lib * fix lint * try conditional for micro import
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Move libinfo into the runtime build * put libinfo back into libtvm * limit microtvm imports when we only have the runtime lib * fix lint * try conditional for micro import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@junrushao1994
We ran into some situations where it would be really nice to have lib information with runtime-only builds. Since we always build the runtime when we build the core tvm target, I figured this was a safe switch. What do you think?