[codegen][LLVM][bugfix] Specify argument to FastMathFlags setAllowContract #9337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9223 added a fast math flags setting to the LLVM codegen. The setting checks if the LLVM version is >= 6.0 and calls the below lines
Recent LLVM versions have a default argument of
true
tollvm::FastMathFlags::setAllowContract()
. However, LLVM 6.0 does not have a default argument for that method, so this fails to compile because it expects an explicit argument. This PR makes the argument explicit to be compatible with LLVM 6.0 (the version my system happened to have).