[Bug][Meta Schedule] Fix Infinite Loop Caused When Calling Methods Not Overridden In PyClass. #9451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxybazh
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
zxybazh
changed the title
junrushao
approved these changes
Nov 5, 2021
|
Oh my spell checker just reminded by that we should "overridden" is the correct word 🤦♂️ |
Merged
zxybazh
changed the title
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…t Overrided In PyClass. (apache#9451) * Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass. * Add new line. * Lint.
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…t Overrided In PyClass. (apache#9451) * Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass. * Add new line. * Lint.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…t Overrided In PyClass. (apache#9451) * Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass. * Add new line. * Lint.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…t Overrided In PyClass. (apache#9451) * Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass. * Add new line. * Lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the infinite loop when you call a PyClass's undefined method. Now that we defined a new helper function decorator
check_overrideand it would make sure a not implemented error would be thrown if the method has no default implementation. And it could still leverage default implementation for methods on the c++ side as shown intest_meta_schedule_task_scheduler.py::test_meta_schedule_task_scheduler_override_next_task_id_onlytest case.To summarize:
NotImplementErrorearly when a class with any required function is missing.