-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TVMScript] Improve printer for TIR syntax sugar #9680
Conversation
e47a560
to
0e0202e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI error and double check if works locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the CI error looks like there are some issues with reads
/writes
in previous PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor issues
This PR intends to improve the printing of three kinds of syntax sugar introduced in TVMScript from #9492, #9620 and #9634. Examples below are supposedly the output of
print(some_tir_prim_func.script())
.Before this PR
After this PR, note that brackets are removed
Before this PR
After this PR, note that all loops with 0 as min will be printed out as syntax sugar
Before this PR
After this PR, note that we assume T.match_buffer with two or less arguments specified are syntax-sugarred.
cc: @vinx13 @junrushao1994 @Hzfengsy