Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] Add a unit test for structural equality #9745

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[Relay] Add a unit test for structural equality #9745

merged 1 commit into from
Dec 15, 2021

Conversation

mbs-octoml
Copy link
Contributor

This is CORE-135 from the forums, which suggested structural equality
was deeply broken. But unable to repro. No harm including unit test.

@mbs-octoml
Copy link
Contributor Author

@comaniac might as well put this in.

comaniac
comaniac approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. Appreciate it.
I'll try to dive deep later by myself again to see how did that happen at my end.

junrushao
junrushao approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for checking this!

@mbs-octoml
[Relay] Add a unit test for structural equality
23faf7c 
This is CORE-135 from the forums, which suggested structural equality
was deeply broken. But unable to repro. No harm including unit test.

(attempt 3)
@masahi masahi merged commit c7ddb41 into apache:main Dec 15, 2021
@mbs-octoml mbs-octoml deleted the mbs-CORE-135 branch December 16, 2021 00:09
AndrewZhaoLuo pushed a commit to AndrewZhaoLuo/tvm that referenced this pull request Dec 16, 2021
@mbs-octoml @AndrewZhaoLuo
[Relay] Add a unit test for structural equality (apache#9745)
2342904 
This is CORE-135 from the forums, which suggested structural equality
was deeply broken. But unable to repro. No harm including unit test.

(attempt 3)
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@mbs-octoml @ylc
[Relay] Add a unit test for structural equality (apache#9745)
487feaa 
This is CORE-135 from the forums, which suggested structural equality
was deeply broken. But unable to repro. No harm including unit test.

(attempt 3)
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@mbs-octoml @ylc
[Relay] Add a unit test for structural equality (apache#9745)
cbf7f65 
This is CORE-135 from the forums, which suggested structural equality
was deeply broken. But unable to repro. No harm including unit test.

(attempt 3)
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
@mbs-octoml
[Relay] Add a unit test for structural equality (apache#9745)
84c07fc 
This is CORE-135 from the forums, which suggested structural equality
was deeply broken. But unable to repro. No harm including unit test.

(attempt 3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@junrushao junrushao junrushao approved these changes

@areusch areusch Awaiting requested review from areusch

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbs-octoml @comaniac @junrushao @masahi