[BUGFIX] Check that virtual device is unchanged in WithFields #9826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electriclilies
requested review from
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
mbs-octoml
approved these changes
Jan 4, 2022
mikepapadim
approved these changes
Jan 4, 2022
|
I also visit the virtual device in the TVMAttrVisitor to ensure that the virtual device is properly copied across the FFI boundary. |
electriclilies
force-pushed
the
with-fields-virtual-device-bug
branch
from
84510b3 to
dd19645
Compare
|
Rebased with #9874 |
masahi
approved these changes
Jan 12, 2022
|
Thanks @masahi! |
Raghav-Chakravarthy
pushed a commit
to Raghav-Chakravarthy/tvm
that referenced
this pull request
Jan 28, 2022
…#9826) * Add default to serialization * revert changes in serialization.cc * update 0.6 converter * json updater working, except for cycles * clean up code * Fix tests * formatting * format : * Check that virtual id is unchanged in WithFields * Set virtual_device_ to fully unconstrained in ctor * visit virtual device in the attr visitor Fix serialization tests * Fix tests after bad merge * Change virtual_device() getter method * lint * ci failed * ci was broken
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…#9826) * Add default to serialization * revert changes in serialization.cc * update 0.6 converter * json updater working, except for cycles * clean up code * Fix tests * formatting * format : * Check that virtual id is unchanged in WithFields * Set virtual_device_ to fully unconstrained in ctor * visit virtual device in the attr visitor Fix serialization tests * Fix tests after bad merge * Change virtual_device() getter method * lint * ci failed * ci was broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, WithFields doesn't check that the virtual device is unchanged, which is incorrect-- this was either a bug or due to a bad merge. I also set the default value of virtual_device_ to FullyUnconstrainedThis change fixes the problem.
NOTE: To make sure that virtual_device_ is propagated across the python boundary, I had to visit the field in VisitAttrs. This changes the serialization of the relay expressions.
@mbs-octoml @mikepapadim