-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microNPU] Add support for nearest neighbor and bilinear upsampling #9841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @lhutton1! I know that there are bits that might still change, but in general LGTM, just some clarifying questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ekalda, as mentioned there will be a follow up which makes a lot of improvement on the first attempt.
a8fecc9
to
038b4a7
Compare
As mentioned previously, a revised implementation has been pushed which removes the need for |
Adds support for 2x2 nearest neighbor and bilinear upsampling. In the case of bilinear upsampling with align_corners set to true, the upsampling size must be `2*input_size - 1` (as opposed to `2*input_size`). Change-Id: I95d215eabfaac983629dcdedcda2b90efb8e0ddf
Change-Id: I840d8ee3671a40c5c99f22119442c349dbed39cf
038b4a7
to
5b41a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks all! this is merged!. |
…pache#9841) * [microNPU] Add support for nearest neighbor and bilinear upsampling Adds support for 2x2 nearest neighbor and bilinear upsampling. In the case of bilinear upsampling with align_corners set to true, the upsampling size must be `2*input_size - 1` (as opposed to `2*input_size`). Change-Id: I95d215eabfaac983629dcdedcda2b90efb8e0ddf * rebase and add support for no-upsampling case. Change-Id: I840d8ee3671a40c5c99f22119442c349dbed39cf
Adds support for 2x2 nearest neighbor and bilinear upsampling. In the case of bilinear upsampling with align_corners set to true, the upsampling size must be
2*input_size - 1
(as opposed to2*input_size
).cc @ekalda @mbaret @jacobbohlin @NicolaLancellotti @dchauhan-arm @manupa-arm